[nrf noup] boot: zephyr: decompression: Fix issues with ARM thumb filter #353
+120
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordicjm
force-pushed
the
fixlzmaarmthumbpr
branch
from
628a468 to
690c58e
Compare
nordicjm
force-pushed
the
fixlzmaarmthumbpr
branch
from
690c58e to
fb13d79
Compare
de-nordic
reviewed
Oct 22, 2024
Comment on lines
+1085
to
+1086
| if ((filter_writeback_pos % sizeof(uint32_t)) != 0) | ||
| { |
Contributor
There was a problem hiding this comment.
OK, so the assumption is that filter_writeback_pos is aligned to at least two bytes? because modulo here can give 1 and 3 as well.
Contributor
Author
There was a problem hiding this comment.
The ARM thumb filter takes in data that is 4-byte aligned and outputs data that is 2-byte aligned so 1 and 3 are not possible
nvlsianpu
approved these changes
Oct 23, 2024
fixup! [nrf noup] zephyr: Add support for ARM thumb filter Fixes some issues with the ARM filter implementation which has been updated to support jump instructions that are staggered into 2 different data chunks, and whereby the final portion of data was not ran through the filter Signed-off-by: Jamie McCrae <[email protected]>
nordicjm
force-pushed
the
fixlzmaarmthumbpr
branch
from
fb13d79 to
2854cac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixup! [nrf noup] zephyr: Add support for ARM thumb filter
Fixes some issues with the ARM filter implementation which has been updated to support jump instructions that are staggered into 2 different data chunks, and whereby the final portion of data was not ran through the filter